744: Service Modification Proposal

Phoenix
1

Service Proposal:

Proposal Value
Are you proposing a change for the service title? No.
Are you proposing a change for the service urls? No.
Are you proposing a change for the service’s wikipedia page? No.
Are you proposing a merge with a different service? No.
Are you proposing ownership changes or does the service not exist anymore? No.

Document Proposal:

Proposal Value
Are you proposing a change for a documents title? No.
If field above has been filled, enter the URL of the document below. None.
— —
Are you proposing a recrawl of a document? true
For which document are you proposing the recrawl? Terms of Service; Didn't Read - Phoenix
— —
Are you proposing a change for a documents xpath? No.
For which document are you proposing the xpath change? None.
Dr_Jeff (Guennadi Maximov C) 2

I’m sad to inform you that a couple days ago I tried to re-crawl the Duolingo docs, but the crawler did not co-operate at all :confused:.

3

Might be an xpath issue perhaps?
Current xpath is /html/body/div[1]/div[1]/div/div for both ToS and Privacy Policy

Dr_Jeff (Guennadi Maximov C) 4

We don’t use XPath anymore. I don’t know when, but we migrated to using CSS selectors.

5

I see.
The Discourse template should probably be changed to reflect that.
Current CSS selector for both is ._2SG0x

Dr_Jeff (Guennadi Maximov C) 6

While it may be valid, we avoid using pure CSS class names as selectors, since they may be repeated on other tags. ID tags (e.g. <tag id="name">) or top-down (e.g. html > body > div > main > section:first-of-type) are prefferable.
Class selectors are still an option, but usually they are a last resort.

Also, let me look into the template for corrections.

7

@ThePainofTOS (UNRELATED) Also did you see the DM I sent you?

8

Yes, I did in fact see it.
I’m thinking about it :smiley: