Changes-Requested Policy

Dr_Jeff · October 25, 2020, 4:01pm

I believe we are all familiar with many services on the Phoenix Site filled with points with changes-requested, and lots of them are very old, deprecated or from deactivated accounts, which ultimately just becomes clutter.

My suggestion is that we should employ a new rule/policy such that a user’s point with changes-requested has a limited time to get changed, and if untouched after such time frame passes, either it switches automatically to declined or curators are authorised to decline them manually.

Of course we could discuss the idea itself, the time frame to give, and whatever else might pop up your head.

So, what do you think?

Yes
No
Other (Could you explain?)

0 voters

Peepo · October 26, 2020, 7:09pm

I agree, what usually happens is that the person never comes back to change them. It would be a lot easier when approving a site if the changes-requested were declined because it opens that case to be used again since we don’t want duplicates. Maybe 6 months is a good cutoff date?

Dr_Jeff · October 30, 2020, 7:47pm

I believe 6 months is a bit of a stretch. Usually people are eager to see a Service reviewed soon. Maybe 2 months?

Arlo · November 7, 2020, 8:47pm

Two months sounds good to me.

michielbdejong · November 23, 2020, 7:41pm

Sure! Sounds good to me.

justin · February 6, 2021, 3:54am

This has been implemented now.

github.com

tosdr/edit.tosdr.org/blob/39ed2c15da7d0ca3269e6930b114e4483290c134/lib/tasks/points.rake#L1-L34


      
          namespace :points do
            desc "Decline points with changes requested"
            task decline_changesrequested: :environment do
          	include FontAwesome::Rails::IconHelper
          	include ApplicationHelper
          	include ActionView::Helpers::TagHelper
              points = Point.all
          	matches = points.where("updated_at < ? and status = 'changes-requested'", 2.months.ago )
          
          
	puts points.length
          	puts matches.length
          
          
    matches.each do |point|
          		point.status = "declined"
                  if point.save
          
          
			puts "Point ID: "+ point.id.to_s
          			@point_comment = PointComment.new()
          			@point_comment.summary = status_badge('declined') + raw('<br>') + 'Point automatically declined as no activity have been monitored over a course of 2 months. Was: changes-requested'
          			@point_comment.user_id = "21311"

This file has been truncated. show original