Phoenix bug when amending excerpts

Arlo · July 11, 2020, 9:49pm

It doesn’t seem to like including the original excerpt as a substring.

works:

doesn’t work:

justin · July 11, 2020, 10:15pm

+1, my fix was to decline my own point and create a new one which of course isn’t feasable for non contributors.

Possible solution would be not to render links when clicking on “Change Excerpt”

Sadly I have little to none experience in ruby and I am not able to make a PR myself. Maybe @michielbdejong could chime in?

justin · July 11, 2020, 10:32pm

Looked through Github and found this line:

github.com

tosdr/edit.tosdr.org/blob/28d714d9eaef6863337bcece4dc076cbd790fcaa/app/views/services/annotate.html.erb#L73-L77


      
          <% if snippet[:pointId] %>
            <p><%= link_to hide_tags(snippet[:text]), point_path(snippet[:pointId]), title: snippet[:title], :data => { :document_id => doc.id, :offset => offset }%></p>
          <% else %>
            <p> <%= content_tag(:div, hide_tags(snippet[:text]), :data => { :document_id => doc.id, :revision => 'latest', :offset => offset }) %> </p>
          <% end %>

Possibly add an if to compare for a matching ID.

if snippet[:pointId] == @point.id or something like that. Which wouldn’t be a problem as the “Change Excerpt” button adds the GET parameter point_id

https://edit.tosdr.org/services/SERVICE_ID/annotate?point_id=POINT_ID

(Line 36 makes use of the GET parameter as well)

github.com

tosdr/edit.tosdr.org/blob/28d714d9eaef6863337bcece4dc076cbd790fcaa/app/views/services/annotate.html.erb#L36


      
                      <option data-case-id="<%= c.id %>"><%= c.title %></option>
                    <% end %>
                  </optgroup>
                <% end %>
              </select>
              <button type="submit" class="btn btn-primary">Annotate</button>
            </form>
          </div>
          <% else %>
          <div class="lead">
            Highlight the lines that support the point <i><%= @point.title %></i>.
          </div>
          <div id="pointToast" class="toast">
            <form id="pointForm">
              <div class="form-group">
                <%= @point.title %>
              </div>
              <button type="submit" class="btn btn-primary">Link to this excerpt</button>
            </form>
          </div>
          <% end %>

Github: Remove link when changing an excerpt · Issue #921 · tosdr/edit.tosdr.org · GitHub

Dr_Jeff · October 5, 2020, 9:21pm

Unfortunately this error persists

justin · October 5, 2020, 9:46pm

Yes I have opened an issue on github for this however development is a bit slow as its voluntarily based.